NO-JIRA: add missing client to controller

[qJkee]

Summary by CodeRabbit

• Chores
  • Enhanced Kubernetes client initialization in security profile management components to ensure proper resource access and system reliability during startup.

[openshift-ci-robot]

@qJkee: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [qJkee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ea9f6ba8-4351-4237-b6e3-94559b86f83f

📥 Commits

Reviewing files that changed from the base of the PR and between 511a308 and 3894603.

📒 Files selected for processing (2)

• cmd/operator/operator.go
• cmd/vgmanager/vgmanager.go

---

Walkthrough

Both cmd/operator/operator.go and cmd/vgmanager/vgmanager.go now explicitly inject the Kubernetes controller-runtime client into SecurityProfileWatcher initialization by setting Client: mgr.GetClient(). No control flow or shutdown behavior was changed.

Changes

Cohort / File(s)	Summary
TLS Profile Watcher Client Injection cmd/operator/operator.go, cmd/vgmanager/vgmanager.go	SecurityProfileWatcher struct initialization now explicitly sets Client: mgr.GetClient() for Kubernetes API access.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 9 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (9 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a missing Kubernetes client to controller initialization in two files.
Stable And Deterministic Test Names	✅ Passed	The PR modifies application initialization files with no Ginkgo test framework calls, making the stable test names check not applicable.
Test Structure And Quality	✅ Passed	Pull request contains only code changes to two non-test files adding Kubernetes client injection to controller structs; no test files modified.
Microshift Test Compatibility	✅ Passed	PR modifies controller initialization code without adding or modifying Ginkgo e2e test definitions, making this check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	SNO test compatibility check applies only to new Ginkgo e2e tests. This PR adds no new e2e tests, only modifies controller setup code.
Topology-Aware Scheduling Compatibility	✅ Passed	Pull request adds Kubernetes client reference to SecurityProfileWatcher controller initialization without introducing topology-incompatible scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR adds client field assignments in SecurityProfileWatcher struct initialization without introducing stdout writes or logging configuration changes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies only controller initialization code, adding a missing Kubernetes client to SecurityProfileWatcher. No new Ginkgo e2e tests are added, making the custom check not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.23%. Comparing base (002c0e6) to head (3894603).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2265      +/-   ##
==========================================
+ Coverage   52.18%   52.23%   +0.05%     
==========================================
  Files          52       52              
  Lines        3896     3896              
==========================================
+ Hits         2033     2035       +2     
+ Misses       1699     1698       -1     
+ Partials      164      163       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[qJkee]

/retest

[openshift-ci]

@qJkee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node	3894603	link	true	/test e2e-aws-single-node
ci/prow/snyk-deps	3894603	link	false	/test snyk-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.