OLS-2604 add google vertex provider#1504
Conversation
Signed-off-by: Haoyu Sun <hasun@redhat.com>
|
/test bundle-e2e-4-21 |
| DefaultMode: volumeDefaultMode, | ||
| }, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
This seems wrong. Vertex does not have to be first. Should be
or i, provider := range cr.Spec.LLMConfig.Providers {
if provider.Type == utils.GoogleVertexType || provider.Type == utils.GoogleVertexAnthropicType {
volumeName := fmt.Sprintf("google-vertex-credential-%d", i)
*volumes = append(*volumes, corev1.Volume{
Name: volumeName,
VolumeSource: corev1.VolumeSource{
Secret: &corev1.SecretVolumeSource{
SecretName: provider.CredentialsSecretRef.Name,
DefaultMode: volumeDefaultMode,
},
},
})
// ... corresponding mount
}
}
| }, | ||
| }, | ||
| }, | ||
| } |
There was a problem hiding this comment.
This test does not check not 1st vertex provider
Signed-off-by: Haoyu Sun <hasun@redhat.com>
|
Hello @blublinsky , I updated the code for better managing the vertex providers for llama stack backend. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: blublinsky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test bundle-e2e-4-21 |
|
@raptorsun: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
Description
This PR adds Google Vertex AI as a provider.
It has 2 types
google_vertexandgoogle_vertex_anthropic, for generic model and Claude models respectively.This only works in combination of the service PR openshift/lightspeed-service#2877
I typical config for google vertex provider can be:
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing