WebSocket streaming alignment & deprecation fixes#268
Merged
sadrasabouri merged 15 commits intodevfrom Mar 19, 2026
Merged
Conversation
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
…and PymiloClient Updated the close method documentation for clarity and streamlined the destructor logic to remove unnecessary try-except blocks. This enhances readability and ensures proper resource management during object destruction.
…mments Improved the cleanup process in the WebSocketClientCommunicator by ensuring the event loop is checked before attempting to disconnect. Additionally, clarified comments in the test file regarding the loading of JSON data for better understanding.
sadrasabouri
requested changes
Mar 4, 2026
Member
sadrasabouri
left a comment
sadrasabouri
left a comment
There was a problem hiding this comment.
I left two comments which is applicable throughout the PR. Can you please fix them and request review me again?
sadrasabouri
requested changes
Mar 5, 2026
Member
sadrasabouri
left a comment
sadrasabouri
left a comment
There was a problem hiding this comment.
I reviewed it again and it required some more changes throught the PR.
…sage handling Updated method signatures to include type hints for better clarity and maintainability. Introduced message constants for download and upload requests to improve code readability and maintainability.
Member
Author
|
Dear Sadra @sadrasabouri, I tried to address your comments as much as possible, let me know if it's good to merge. |
sadrasabouri
approved these changes
Mar 19, 2026
Member
sadrasabouri
left a comment
sadrasabouri
left a comment
There was a problem hiding this comment.
I reviewed it but there are still some inconsistencies, such as using Dict and dict. It can be solved later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
scenario4test for access control features on both protocolsget_allowancereturning 404 on empty allowancesPymiloClientandWebSocketClientCommunicatorAny other comments?