Add Monthly Amortized Cost chart and update AWS Benchmark metrics#2077
Merged
Add Monthly Amortized Cost chart and update AWS Benchmark metrics#2077
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AWS Benchmark analytics dashboard bundle to add a new “Monthly Amortized Cost Over Time” chart and to adjust several existing KPI/table visualizations and dashboard layout.
Changes:
- Added a new Timeseries dataset asset and a new “Monthly Amortized Cost Over Time” chart, wiring them into the AWS Benchmark dashboard and seeding flow.
- Updated “Unified Cost Efficiency Metric” calculation and conditional color thresholds.
- Updated formatting for “Top opportunities to address” (Percent column) and removed conditional formatting from “Estimated Monthly Savings”.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/server/api/src/assets/aws-benchmark-dashboard/datasets/openops_tables_connection/AWS_Benchmark_Timeseries.yaml | Adds dataset asset backing the new monthly amortized cost chart. |
| packages/server/api/src/assets/aws-benchmark-dashboard/dashboards/AWS_Benchmark.yaml | Updates layout, adds chart 9 to the first row, and adds a new markdown row. |
| packages/server/api/src/assets/aws-benchmark-dashboard/charts/Unified_Cost_Efficiency_Metric_8.yaml | Updates KPI metric SQL and conditional formatting tiers. |
| packages/server/api/src/assets/aws-benchmark-dashboard/charts/Top_opportunities_to_address_3.yaml | Adds percent formatting for the “Percent” column. |
| packages/server/api/src/assets/aws-benchmark-dashboard/charts/Monthly_Amortized_Cost_Over_Time_9.yaml | Introduces new chart configuration for monthly amortized cost. |
| packages/server/api/src/assets/aws-benchmark-dashboard/charts/Estimated_Monthly_Savings_1.yaml | Removes conditional formatting highlight rules. |
| packages/server/api/src/app/openops-analytics/benchmark/create-aws-benchmark-datasets.ts | Seeds a new virtual dataset for AWS_Benchmark_Timeseries. |
| packages/server/api/src/app/openops-analytics/benchmark/create-aws-benchmark-dashboard.ts | Maps the new dataset UUID into the Superset dashboard import step. |
Comments suppressed due to low confidence (1)
packages/server/api/src/assets/aws-benchmark-dashboard/charts/Estimated_Monthly_Savings_1.yaml:55
params.conditional_formattingis cleared, butquery_contextstill contains the oldconditional_formattingrule inform_data. This leaves the exported chart definition internally inconsistent and risks the old formatting reappearing depending on how Superset ingestsquery_contexton import. Updatequery_contextto match (or remove it if it’s not required in these exports).
conditional_formatting: []
extra_form_data: {}
dashboards:
- 2
- 1
query_context:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
...ets/aws-benchmark-dashboard/datasets/openops_tables_connection/AWS_Benchmark_Timeseries.yaml
Show resolved
Hide resolved
...server/api/src/assets/aws-benchmark-dashboard/charts/Monthly_Amortized_Cost_Over_Time_9.yaml
Outdated
Show resolved
Hide resolved
...s/server/api/src/assets/aws-benchmark-dashboard/charts/Unified_Cost_Efficiency_Metric_8.yaml
Show resolved
Hide resolved
packages/server/api/src/assets/aws-benchmark-dashboard/dashboards/AWS_Benchmark.yaml
Show resolved
Hide resolved
...ets/aws-benchmark-dashboard/datasets/openops_tables_connection/AWS_Benchmark_Timeseries.yaml
Show resolved
Hide resolved
...server/api/src/assets/aws-benchmark-dashboard/charts/Monthly_Amortized_Cost_Over_Time_9.yaml
Outdated
Show resolved
Hide resolved
...s/server/api/src/assets/aws-benchmark-dashboard/charts/Unified_Cost_Efficiency_Metric_8.yaml
Show resolved
Hide resolved
...s/server/api/src/assets/aws-benchmark-dashboard/charts/Unified_Cost_Efficiency_Metric_8.yaml
Show resolved
Hide resolved
...ges/server/api/src/assets/aws-benchmark-dashboard/charts/Top_opportunities_to_address_3.yaml
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 934f9e9.
|
MarceloRGonc
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes OPS-3858.
This PR uses the latest exported version of the baseline analytics dashboard.
Here's a summary of the existing chart updates:
Estimated Monthly Savings — Removed the green cell highlight that appeared when savings exceeded zero. The number now displays cleanly without background coloring.
Top Opportunities to Address — Added proper percentage formatting for the "Percent" column, so values display as e.g. 12.5% instead of a raw decimal.
Unified Cost Efficiency Metric — Two improvements:
The underlying calculation now handles edge cases (zero cost, negative or out-of-range results) more gracefully, returning 0 instead of crashing or showing unexpected values.
The color coding was upgraded from a single red threshold to a three-tier system: red (below 80%), yellow (80–90%), and green (90%+), giving a clearer at-a-glance health signal.