Implementing blitting for colorbar indicators#168
Merged
pshriwise merged 3 commits intoopenmc-dev:developfrom Jan 23, 2026
Merged
Implementing blitting for colorbar indicators#168pshriwise merged 3 commits intoopenmc-dev:developfrom
pshriwise merged 3 commits intoopenmc-dev:developfrom
Conversation
pshriwise
approved these changes
Jan 23, 2026
Collaborator
pshriwise
left a comment
pshriwise
left a comment
There was a problem hiding this comment.
Looks great! I updated the name of the PlotImage.colorbar attribute to something a little more descriptive that was pre-existing (the corresponding colorbar background cache name as well). Hope that's alright. There was a section of code that was throwing me a bit in PlotImage._blit_indicator where a background cache is selected. It helps there in particular I think.
I don't know that I've used the data indicator feature in a while, so thanks for noticing and addressing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently tried using the data indicator with a mesh tally displayed in the plotter and found that it was practically unusable because it caused a full redraw of the image each time the mouse moved. This PR changes the indicator updates to use blitting so that updating the indicator line can be done quickly without redrawing the full image.