Doc - how to add custom press or journal a11y info#217
Open
StephDriver wants to merge 5 commits into
Open
Conversation
StephDriver
force-pushed
the
b-5290-a11y-manager-doc
branch
from
146fa50 to
6b977a2
Compare
S-Haime
reviewed
Apr 30, 2026
Member
S-Haime
left a comment
S-Haime
left a comment
There was a problem hiding this comment.
I know there are a few comments, but mostly formatting issues easily resolved - I have linked the styleguide and appropriate sections.
The main point for me lies in the Quick reference section, which could be improved with some context for users and a quick example of what some of it would mean in practice.
But looks good generally, please don't be discouraged by the many comments! I've tried to be thorough (Joe is much better at sounding friendly in writing than I) :) ! Let me know if anything is unclear or you want some help with this.
S-Haime
requested changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes openlibhums/janeway#5290