Skip to content

7904167: Enable -03 optimization in NativeCompilation.gmk#302

Open
varada1110 wants to merge 1 commit intoopenjdk:masterfrom
varada1110:7904167
Open

7904167: Enable -03 optimization in NativeCompilation.gmk#302
varada1110 wants to merge 1 commit intoopenjdk:masterfrom
varada1110:7904167

Conversation

@varada1110
Copy link
Copy Markdown

@varada1110 varada1110 commented Mar 18, 2026

Enable -03 in make/NativeCompilation.gmk to align with Gradle CMake Release optimization.

JBS : CODETOOLS-7904167


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (no review required)

Error

 ⚠️ Pull request body is missing required line: - [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/302/head:pull/302
$ git checkout pull/302

Update a local copy of the PR:
$ git checkout pull/302
$ git pull https://git.openjdk.org/jextract.git pull/302/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 302

View PR using the GUI difftool:
$ git pr show -t 302

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/302.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 18, 2026

👋 Welcome back varadam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 18, 2026

@varada1110 This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk Bot changed the title CODETOOLS-7904167: Enable -03 optimization in NativeCompilation.gmk 7904167: Enable -03 optimization in NativeCompilation.gmk Mar 18, 2026
@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Mar 18, 2026

Webrevs

@varada1110
Copy link
Copy Markdown
Author

Hi @JornVernee , could I please get a review on this.

@varada1110
Copy link
Copy Markdown
Author

Hi @JornVernee , @mcimadamore
could I please get a review for this PR

Copy link
Copy Markdown
Member

@nizarbenalla nizarbenalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the change is straightforward.
But let's wait for Jorn to have a good.

@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 20, 2026
@JornVernee
Copy link
Copy Markdown
Member

Hey, I was on vacation the last couple of weeks, and didn't have time to look at this before that.

There's a couple things I'd like to understand:

  • Are you using the Makefile build? I'm assuming the answer is "yes", but the makefile build was only intended for Oracle internal CI use.
  • We only use the native compiler to build test libraries. Why is it important to keep the optimization level in sync between the two builds for tests libraries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants