7904167: Enable -03 optimization in NativeCompilation.gmk#302
Open
varada1110 wants to merge 1 commit intoopenjdk:masterfrom
Open
7904167: Enable -03 optimization in NativeCompilation.gmk#302varada1110 wants to merge 1 commit intoopenjdk:masterfrom
varada1110 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back varadam! A progress list of the required criteria for merging this PR into |
|
@varada1110 This change is no longer ready for integration - check the PR body for details. |
Author
|
Hi @JornVernee , could I please get a review on this. |
Author
|
Hi @JornVernee , @mcimadamore |
nizarbenalla
approved these changes
Apr 20, 2026
Member
nizarbenalla
left a comment
There was a problem hiding this comment.
Looks good to me, the change is straightforward.
But let's wait for Jorn to have a good.
Member
|
Hey, I was on vacation the last couple of weeks, and didn't have time to look at this before that. There's a couple things I'd like to understand:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable -03 in make/NativeCompilation.gmk to align with Gradle CMake Release optimization.
JBS : CODETOOLS-7904167
Progress
Error
- [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/302/head:pull/302$ git checkout pull/302Update a local copy of the PR:
$ git checkout pull/302$ git pull https://git.openjdk.org/jextract.git pull/302/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 302View PR using the GUI difftool:
$ git pr show -t 302Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/302.diff
Using Webrev
Link to Webrev Comment