Conversation
…bility Ensure no regressions are introduced, run: prove t/db_dependent/Koha/AdditionalContents.t
prove t/db_dependent/api/v1/additional_contents.t
mrenvoize
commented
May 14, 2025
| branchcode => 'library_id', | ||
| published_on => 'published_on', | ||
| updated_on => 'updated_on', | ||
| expirationdate => 'expirationdate', |
Member
Author
There was a problem hiding this comment.
We have a mix of expiry_date and expiration_date in the API to date.. I think I'm leaning towards the latter as it's just about got more occurrences.
| published_on => 'published_on', | ||
| updated_on => 'updated_on', | ||
| expirationdate => 'expirationdate', | ||
| number => 'number', |
Member
Author
There was a problem hiding this comment.
number... how descriptive. I 'think' this acts as priority/index in the array as such.. so might be better named something more meaningful for the API?
Member
Author
|
I also wonder if in this first pass we drop the localization support... for public I reckon that probably aught to actually follow the lang support of the API that people have been working on.. i.e. not embed but rather return the correct version depending on which one you asked for.. for the admin side that's harder to think about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.