Refactor component creation and retrieval logic; enhance error handli…#17
Refactor component creation and retrieval logic; enhance error handli…#17
Conversation
…ng and response mapping
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
…onException; include additional messages for validation errors
…eck for empty strings
…evstack/ods-api-service into chore/component-api-error-handling
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
1 similar comment
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
| - DEV | ||
| - QA | ||
| - PROD | ||
| EnvironmentsStatusDTO: |
There was a problem hiding this comment.
This is not the status of the environment, it is the status of the Component / Project provisioning
| type: string No newline at end of file | ||
| description: Additional parameters (key-value pairs) | ||
| additionalProperties: true | ||
| EnvironmentsTypeDTO: |
There was a problem hiding this comment.
Check if it is needed for the new Markeplace 2.0
| OK("000", "Success"), | ||
| ACCESS_DENIED("002", "Forbidden"), | ||
| INTERNAL_ERROR("003", "Internal error"), | ||
| INVALID_PARAMETERS("006", badRequest()), |
There was a problem hiding this comment.
Check how is done in the project api with ErrorKeys to use the number + message
|
|
||
| return createComponentRequest.getParams().entrySet().stream() | ||
| .map(entry -> new CreateComponentParameter(entry.getKey(), "string", entry.getValue())) | ||
| .map(this::toCreateComponentParameter) |
| ONCE_PER_PROJECT("009", ErrorMessage.FORBIDDEN), | ||
| COMPONENT_PARAM_NOT_MEET_REGEX("010", ErrorMessage.BAD_REQUEST), | ||
| INVALID_LOCATION("011", ErrorMessage.BAD_REQUEST), | ||
| INVALID_LOCATION("011", "Incorrect location. Valid locations are:"), |
There was a problem hiding this comment.
Add the message to the errormessage class
jorge-romero
left a comment
jorge-romero
left a comment
There was a problem hiding this comment.
Please review the comments.
…mponentErrorKey and ErrorKey
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
…o EnvironmentsDTO and EnvironmentsStatusDTO to ComponentsStatusDTO for consistency
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
|
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
3 participants
…ng and response mapping