fix: require explicit ACPX auth envs for ACP auth selection#248
Open
valkyriweb wants to merge 1 commit intoopenclaw:mainfrom
Open
fix: require explicit ACPX auth envs for ACP auth selection#248valkyriweb wants to merge 1 commit intoopenclaw:mainfrom
valkyriweb wants to merge 1 commit intoopenclaw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247
acpxand the normalcodexCLI intentionally share the same Codex auth state. That part is fine.The bug is that starting a Codex session through
acpxcould overwrite that shared auth instead of just reusing it.If the parent environment had
OPENAI_API_KEYset,acpxcould treat it as an ACP auth credential, selectopenai-api-keyduring startup, and sendcodex-acpdown its API-key login path. In practice that meant an existing ChatGPT OAuth login could be replaced on disk, and latercodexCLI runs would start using the API key instead.This change keeps explicit ACP auth working, but stops ambient provider env from participating in auth-method selection.
Only these should drive ACP
authenticateselection:authentriesACPX_AUTH_<METHOD_ID>env varsAmbient provider env like
OPENAI_API_KEYcan still exist in the process environment, but it should not be enough on its own to rewrite shared Codex auth.What changed
ACPX_AUTH_*env vars count as ACP auth input during auth-method selectionauthentries still work as beforeACPX_AUTH_*values are still promoted into the child environment for adapters that expect normalized names likeOPENAI_API_KEYVerification
pnpm run checkpnpm run check:docsAI-assisted change.