Open
Conversation
Coverage Report
File CoverageNo changed files found. |
scheidtdav
approved these changes
Apr 17, 2026
Member
scheidtdav
left a comment
scheidtdav
left a comment
There was a problem hiding this comment.
Please check this potential break before merging
Comment on lines
+53
to
+56
| // useEffect(() => { | ||
| // cleanSearchParams() | ||
| // // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| // }, []) |
Member
There was a problem hiding this comment.
I think this might break existing functionality right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Implementation
Requires these discourse settings:
enable_discourse_connect: truediscourse_connect_url: osem api routediscourse_connect_secret: shared secretAdd an api route to the app for the discourse
discourse_connect_urlsetting and to implement this flow:User opens Discourse
|
v
User clicks "Login"
|
v
Discourse creates a nonce and builds:
/api/discourse/sso?sso=...&sig=...
|
v
Browser redirect to osem
|
v
osem verifies sig using the shared secret
|
v
osem decodes sso and reads:
- nonce
- return_sso_url
|
v
Redirect to osem login and then back to the same SSO URL
|
v
osem builds response payload:
- nonce
- external_id
- email
- username
|
v
osem base64-encodes payload and signs it with the same secret
|
v
Browser redirect to:
return_sso_url?sso=...&sig=...
|
v
Discourse verifies signature and nonce
|
v
Discourse finds or creates the user
|
v
User is logged into the forum
Checklist
devbranchAdditional Information