Open
Conversation
Collaborator
AadilLatif
commented
Apr 7, 2026
AadilLatif
commented
- Add submodules: pnnl-hub-voltage, pnnl-hub-control, pnnl-hub-power, pnnl-dsse-ekf, pnnl-imputation-ffnn, pnnl-profiler-sdv
- Register hub and EKF components in components.json
- Add pnnl-dsse-ekf to unit test matrix (Python 3.13 only)
- Skip non-federate submodules in verify workflows
- Update README component status table and component list
- Add submodules: pnnl-hub-voltage, pnnl-hub-control, pnnl-hub-power, pnnl-dsse-ekf, pnnl-imputation-ffnn, pnnl-profiler-sdv - Register hub and EKF components in components.json - Add pnnl-dsse-ekf to unit test matrix (Python 3.13 only) - Skip non-federate submodules in verify workflows - Update README component status table and component list
slay-pnnl
approved these changes
Apr 15, 2026
|
The Unit Test - Components / test (3.13, pnnl-dsse-ekf) seems very difficult to accomplish. The EKF algorithm is a C++ library with a very large number of deps. Do you have any ideas for a path forward? |
slay-pnnl
approved these changes
Apr 15, 2026
slay-pnnl
left a comment
slay-pnnl
left a comment
There was a problem hiding this comment.
If the unit test doesn't need to be updated, everything else makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.