Skip to content

fix(test): OmdURLConfiguration failure for AUT#28877

Merged
chirag-madlani merged 3 commits into
mainfrom
fix-omdRULConfiguration-spec
Jun 10, 2026
Merged

fix(test): OmdURLConfiguration failure for AUT#28877
chirag-madlani merged 3 commits into
mainfrom
fix-omdRULConfiguration-spec

Conversation

@chirag-madlani

@chirag-madlani chirag-madlani commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Describe your changes:

Fixes #

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • Test Fixes:
    • Updated OmdURLConfiguration.spec.ts to accept both 'OpenMetadata' or 'Collate' in success toast messages.
    • Updated bot.ts utility to regex-match 'JWTToken' and removed an incorrect assertion on the center-panel test ID.

This will update automatically on new commits.

@chirag-madlani chirag-madlani requested a review from a team as a code owner June 9, 2026 14:28
@chirag-madlani chirag-madlani added skip-pr-checks Bypass PR metadata validation check To release Will cherry-pick this PR into the release branch labels Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

karanh37
karanh37 previously approved these changes Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
62.81% (67163/106923) 44.03% (37055/84155) 46.4% (11397/24559)

Comment thread openmetadata-ui/src/main/resources/ui/playwright/utils/bot.ts
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (8 flaky)

✅ 4276 passed · ❌ 0 failed · 🟡 8 flaky · ⏭️ 88 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 300 0 1 4
🟡 Shard 2 804 0 2 9
🟡 Shard 3 807 0 1 8
🟡 Shard 4 842 0 1 12
🟡 Shard 5 720 0 1 47
🟡 Shard 6 803 0 2 8
🟡 8 flaky test(s) (passed on retry)
  • Pages/SearchSettings.spec.ts › Preview config reflects reverted n-gram weight after save (shard 1, 1 retry)
  • Features/DataQuality/ColumnLevelTests.spec.ts › Column Values To Be Not Null (shard 2, 1 retry)
  • Features/Glossary/GlossaryHierarchy.spec.ts › should cancel move operation (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate Description Rule Is_Set (shard 4, 1 retry)
  • Pages/EntityDataConsumer.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/ODCSImportExport.spec.ts › Multi-object ODCS contract - object selector shows all schema objects (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@chirag-madlani chirag-madlani merged commit 8e99994 into main Jun 10, 2026
54 of 56 checks passed
@chirag-madlani chirag-madlani deleted the fix-omdRULConfiguration-spec branch June 10, 2026 04:29
@gitar-bot

gitar-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Updates OmdURLConfiguration and bot utility tests to correctly handle dynamic success messages and token regex, resolving the empty toContainText assertion.

✅ 1 resolved
Bug: toContainText() called with no expected argument

📄 openmetadata-ui/src/main/resources/ui/playwright/utils/bot.ts:35 📄 openmetadata-ui/src/main/resources/ui/playwright/utils/bot.ts:123
In createBot, line 123 was changed to await expect(page.getByTestId('center-panel')).toContainText(); — the expected value argument was dropped entirely. Playwright's toContainText requires an expected string/RegExp/array; calling it with no argument is a TypeScript error (tsc will fail, violating the CI/CD rule) and at runtime the assertion no longer verifies that the JWT token is rendered, so it provides no coverage.

The new JWTToken: /(OpenMetadata|Collate) JWT Token/ regex field added at line 35 is now unused, indicating the intent was to assert against it. The previous assertion used ${BOT_DETAILS.JWTToken} Token; since the regex already includes Token, the call should pass the regex directly.

Suggested fix:

await expect(page.getByTestId('center-panel')).toContainText(
  BOT_DETAILS.JWTToken
);
Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions

Copy link
Copy Markdown
Contributor

Failed to cherry-pick changes to the 1.12.11 branch.
Please cherry-pick the changes manually.
You can find more details here.

@github-actions

Copy link
Copy Markdown
Contributor

Changes have been cherry-picked to the 1.13 branch.

github-actions Bot pushed a commit that referenced this pull request Jun 10, 2026
chirag-madlani added a commit that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants