Skip to content

fixes: 28703#28873

Open
satender-kumar-collate wants to merge 7 commits into
mainfrom
fix/28703
Open

fixes: 28703#28873
satender-kumar-collate wants to merge 7 commits into
mainfrom
fix/28703

Conversation

@satender-kumar-collate

@satender-kumar-collate satender-kumar-collate commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #28703

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

image image image image

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • Explore UI enhancements:
    • Display total asset count in Explore when active filters or search queries are applied.
    • Added hasActiveFilters logic to track state of queryFilter, quickFilters, sqlQuery, and searchQueryParam.
    • Improved GlobalSearchBar to persist filters when clearing search queries.
  • Testing and infrastructure:
    • Added comprehensive Playwright E2E tests in AdvancedSearch.spec.ts for count visibility.
    • Added unit tests for SearchedData and ExploreV1 components to verify correct count rendering.
    • Updated admin.ts and UserClass.ts to use domcontentloaded wait strategy for better test reliability.
    • Updated jest.config.js to mock codemirror dependencies.

This will update automatically on new commits.

…tive (#28703)

- Render search-results-count in SearchedData when showResultCount=true
- Pass showResultCount={hasActiveFilters} from ExploreV1 so the count
  appears only when a search query, quick filter, or advanced search
  filter is active — hidden in bare browse mode
- Fix GlobalSearchBar clear button to navigate with search='' when on
  the Explore page, so clearing the search bar also resets the count
  and results back to browse mode
- Fix Playwright auth/teardown timeouts by using domcontentloaded
  instead of load strategy in UserClass.ts and admin.ts
- Add unit tests for SearchedData count visibility and ExploreV1
  showResultCount prop propagation
- Add E2E tests for count show/hide behaviour in AdvancedSearch.spec.ts

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@satender-kumar-collate satender-kumar-collate requested a review from a team as a code owner June 9, 2026 13:34
@satender-kumar-collate satender-kumar-collate added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jun 9, 2026

@chirag-madlani chirag-madlani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach screenshot / video with changes

Comment on lines +78 to +79
'^codemirror(/.*)?$': '<rootDir>/src/test/unit/mocks/file.mock.js',
'^react-codemirror2$': '<rootDir>/src/test/unit/mocks/file.mock.js',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why codeMirror changes?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codemirror is a transitive dependancy here through ExploreV1.test & SearchedData.test that's why these lines were added.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (10 flaky)

✅ 4276 passed · ❌ 0 failed · 🟡 10 flaky · ⏭️ 88 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 301 0 0 4
🟡 Shard 2 802 0 3 9
🟡 Shard 3 804 0 3 8
✅ Shard 4 847 0 0 12
🟡 Shard 5 718 0 3 47
🟡 Shard 6 804 0 1 8
🟡 10 flaky test(s) (passed on retry)
  • Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › Admin: Complete export-import-validate flow (shard 2, 1 retry)
  • Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › EditAll User: Complete export-import-validate flow (shard 2, 1 retry)
  • Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Features/Table.spec.ts › Table pagination with sorting should works (shard 3, 1 retry)
  • Features/Tasks/DomainFiltering.spec.ts › selecting All Domains removes domain filter from feed API call (shard 3, 1 retry)
  • Pages/Entity.spec.ts › Tag and Glossary Term preservation in column detail panel (shard 5, 1 retry)
  • Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
  • Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot

gitar-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Implements total asset count display for active Explore filters and adds support for extensible user-profile dropdown items. The cleanup of a commented-out code block in ExploreV1 was addressed, and no issues were found.

✅ 1 resolved
Quality: Leftover commented-out SearchedData block in ExploreV1

📄 openmetadata-ui/src/main/resources/ui/src/components/ExploreV1/ExploreV1.component.tsx:649-659
A duplicated, commented-out <SearchedData ... /> block (lines 649-659) was left directly above the live <SearchedData> render. It appears to be a leftover from iterating on the fix (the commented version still uses isFilterSelected as a boolean literal). Dead commented code adds noise and contradicts the self-documenting-code guideline. Remove the commented block.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show total asset count for Advanced Search / filtered results on Explore page

2 participants