fixes: 28703#28873
Conversation
…tive (#28703) - Render search-results-count in SearchedData when showResultCount=true - Pass showResultCount={hasActiveFilters} from ExploreV1 so the count appears only when a search query, quick filter, or advanced search filter is active — hidden in bare browse mode - Fix GlobalSearchBar clear button to navigate with search='' when on the Explore page, so clearing the search bar also resets the count and results back to browse mode - Fix Playwright auth/teardown timeouts by using domcontentloaded instead of load strategy in UserClass.ts and admin.ts - Add unit tests for SearchedData count visibility and ExploreV1 showResultCount prop propagation - Add E2E tests for count show/hide behaviour in AdvancedSearch.spec.ts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chirag-madlani
left a comment
There was a problem hiding this comment.
Please attach screenshot / video with changes
| '^codemirror(/.*)?$': '<rootDir>/src/test/unit/mocks/file.mock.js', | ||
| '^react-codemirror2$': '<rootDir>/src/test/unit/mocks/file.mock.js', |
There was a problem hiding this comment.
Why codeMirror changes?
There was a problem hiding this comment.
codemirror is a transitive dependancy here through ExploreV1.test & SearchedData.test that's why these lines were added.
🟡 Playwright Results — all passed (10 flaky)✅ 4276 passed · ❌ 0 failed · 🟡 10 flaky · ⏭️ 88 skipped
🟡 10 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code Review ✅ Approved 1 resolved / 1 findingsImplements total asset count display for active Explore filters and adds support for extensible user-profile dropdown items. The cleanup of a commented-out code block in ExploreV1 was addressed, and no issues were found. ✅ 1 resolved✅ Quality: Leftover commented-out SearchedData block in ExploreV1
OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Describe your changes:
Fixes #28703
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Summary by Gitar
Explorewhen active filters or search queries are applied.hasActiveFilterslogic to track state ofqueryFilter,quickFilters,sqlQuery, andsearchQueryParam.GlobalSearchBarto persist filters when clearing search queries.AdvancedSearch.spec.tsfor count visibility.SearchedDataandExploreV1components to verify correct count rendering.admin.tsandUserClass.tsto usedomcontentloadedwait strategy for better test reliability.jest.config.jsto mockcodemirrordependencies.This will update automatically on new commits.