Skip to content

add column tag filtering to advanced search functionality#28871

Open
Rohit0301 wants to merge 4 commits into
mainfrom
fix-4434
Open

add column tag filtering to advanced search functionality#28871
Rohit0301 wants to merge 4 commits into
mainfrom
fix-4434

Conversation

@Rohit0301

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes 4434
Screenshot 2026-06-09 at 6 22 48 PM

Screen.Recording.2026-06-09.at.6.28.24.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

@Rohit0301 Rohit0301 self-assigned this Jun 9, 2026
@Rohit0301 Rohit0301 requested a review from a team as a code owner June 9, 2026 13:00
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Jun 9, 2026
@Rohit0301 Rohit0301 changed the title feat: add column tag filtering to advanced search functionality add column tag filtering to advanced search functionality Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

Comment thread openmetadata-ui/src/main/resources/ui/src/locale/languages/pr-pr.json Outdated
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
62.73% (67132/107001) 44% (37029/84152) 46.3% (11390/24596)

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (13 flaky)

✅ 3473 passed · ❌ 0 failed · 🟡 13 flaky · ⏭️ 79 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 301 0 0 4
🟡 Shard 3 809 0 3 8
🟡 Shard 4 843 0 4 12
🟡 Shard 5 720 0 1 47
🟡 Shard 6 800 0 5 8
🟡 13 flaky test(s) (passed on retry)
  • Features/KnowledgeCenterList.spec.ts › Knowledge Center List - Verify Recently Viewed widget (shard 3, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Features/Table.spec.ts › Table pagination with sorting should works (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 4, 1 retry)
  • Pages/CustomProperties.spec.ts › Table (shard 4, 1 retry)
  • Pages/CustomProperties.spec.ts › Entity Reference List (shard 4, 1 retry)
  • Pages/DomainAdvanced.spec.ts › Filter assets by domain from explore page (shard 4, 1 retry)
  • Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 1 retry)
  • Pages/ExplorePageRightPanel.spec.ts › Should allow Data Consumer to edit description for searchIndex (shard 6, 1 retry)
  • Pages/Glossary.spec.ts › Async Delete - multiple deletes all succeed (shard 6, 1 retry)
  • Pages/GlossaryFormValidation.spec.ts › should show error when term description is empty (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • VersionPages/GlossaryVersionPage.spec.ts › Navigate between versions (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot

gitar-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 2 resolved / 2 findings

Adds column tag filtering to the advanced search functionality, resolving inconsistencies in tag suggestions and fixing the Portuguese localization for column tag labels.

✅ 2 resolved
Quality: pr-pr.json uses Portuguese text for column-tag-plural

📄 openmetadata-ui/src/main/resources/ui/src/locale/languages/pr-pr.json:372
The new column-tag-plural key in the Persian locale (pr-pr.json) was given the Portuguese value "Etiquetas de coluna", while every surrounding string in that file is written in Persian (e.g. "column-status": "وضعیت ستون"). This looks like a copy-paste from pt-br.json/pt-pt.json. Persian users will see the column-tag filter label in Portuguese. Replace it with the correct Persian translation (e.g. "برچسب‌های ستون").

Bug: Column tag suggestions inconsistent between Explore and rules engine

📄 openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchClassBase.ts:1141-1144 📄 openmetadata-ui/src/main/resources/ui/src/utils/JSONLogicSearchClassBase.ts:338-342
In AdvancedSearchClassBase.getColumnTagConfig the async suggestion fetch searches both SearchIndex.TAG and SearchIndex.GLOSSARY_TERM, so the Explore-page filter offers classification tags and glossary terms as column-tag values. The corresponding JSONLogic (rules/alerts) config at JSONLogicSearchClassBase only queries SearchIndex.TAG, so glossary terms applied to columns cannot be suggested/selected there. Since columns can be tagged with glossary terms, this is an inconsistency that prevents filtering on glossary-term column tags in the JSONLogic builder. Consider aligning the two by also including SearchIndex.GLOSSARY_TERM (note: the existing top-level TAG field in JSONLogicSearchClassBase has the same single-index limitation, so confirm this is intended).

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant