Fixes #28869: migrate greenplum and cockroach connectors to BaseConnection

[IceS2]

What

Migrates the greenplum and cockroach connectors from module-level get_connection/test_connection to a BaseConnection subclass — continuing the database-connector migration (follows #28854 and #28866).

Both are basic-auth-only, Postgres-dialect connectors with a single client-build path, so each:

• defines XConnection(BaseConnection[XConfig, Engine]) whose _get_client() builds the engine via the shared BasicAuthStrategy,
• moves test_connection into the class (calling the same test_connection_db_common helper, preserving each connector's custom GetDatabases query),
• registers connection_class= in its service_spec.py,
• drops the old module-level functions.

No match on authType: although these configs carry an authType field, the previous get_connection never branched on it (it always built a plain engine), so BasicAuthStrategy reproduces the exact prior behavior.

Tests

Colocated per-connector unit tests under tests/unit/source/database/{greenplum,cockroach}/test_connection.py asserting the engine URL built through the connector (postgresql+psycopg2://… / cockroachdb+psycopg2://…). ruff + basedpyright clean.

Validation

Ran real metadata ingestion using this branch's connector code into a running OpenMetadata — both 100% success, 0 errors, tables + views ingested with correct columns:

• greenplum → Postgres backend (Greenplum uses the postgresql+psycopg2 dialect + standard introspection).
• cockroach → real CockroachDB v23.1 container (start-single-node --insecure): test-connection passed (CheckAccess/GetDatabases/GetSchemas/GetTables/GetViews), tables + view ingested.

Note: CockroachDB v23.2+ moves start-single-node into a virtual cluster that restricts crdb_internal/system access, which the source's reflection queries rely on — a source/version concern independent of this connection refactor (the engine is byte-identical to the previous get_connection).

Scope

greenplum + cockroach only. Next batch: doris + starrocks.

Fixes #28869

[github-actions]

✅ PR checks passed

The linked issue has a description and all required Shipping project fields set. Thanks!

[sonarqubecloud]

Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🟡 Playwright Results — all passed (12 flaky)

✅ 4272 passed · ❌ 0 failed · 🟡 12 flaky · ⏭️ 88 skipped

Shard	Passed	Failed	Flaky	Skipped
✅ Shard 1	301	0	0	4
🟡 Shard 2	802	0	4	9
🟡 Shard 3	807	0	1	8
🟡 Shard 4	842	0	1	12
🟡 Shard 5	720	0	1	47
🟡 Shard 6	800	0	5	8

🟡 12 flaky test(s) (passed on retry)

• Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › Admin: Complete export-import-validate flow (shard 2, 1 retry)
• Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 2, 1 retry)
• Features/Glossary/GlossaryWorkflow.spec.ts › should display correct status badge color and icon (shard 2, 2 retries)
• Features/Glossary/GlossaryWorkflow.spec.ts › should start term as Draft when glossary has reviewers (shard 2, 2 retries)
• Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
• Pages/CustomProperties.spec.ts › Should display custom properties for apiCollection in right panel (shard 4, 1 retry)
• Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 1 retry)
• Pages/Glossary.spec.ts › Column dropdown drag-and-drop functionality for Glossary Terms table (shard 6, 1 retry)
• Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Container (shard 6, 1 retry)
• Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for dashboard -> dashboardDataModel (shard 6, 1 retry)
• Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
• Pages/Lineage/PlatformLineage.spec.ts › Verify domain platform view (shard 6, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

[gitar-bot]

Code Review ✅ Approved

Migrates Greenplum and Cockroach connectors to the BaseConnection framework using BasicAuthStrategy, preserving original connection behavior. Verified via successful metadata ingestion and unit testing with no issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}