fix(issuer): refresh badge count after award/revoke

[fatimakay]

See Issue #2017

[onemanwenttomow]

Hi @fatimakay, great fix! Two small suggestions:

1. Flatten the promise chain so .catch() covers updateList() failures too (currently it only catches errors from firstValueFrom onwards):

this.badgesLoaded = this.badgeClassService.badgesList
    .updateList()
    .then(() => firstValueFrom(this.badgeClassService.badgesByIssuerUrl$))
    .then((badgesByIssuer) => {
        const cmp = (a, b) => (a === b ? 0 : a < b ? -1 : 1);
        this.badges = (badgesByIssuer[this.issuer.issuerUrl] || []).sort((a, b) =>
            cmp(b.createdAt, a.createdAt),
        );
    })
    .catch((error) => {
        this.messageService.reportAndThrowError(
            `Failed to load badges for ${this.issuer ? this.issuer.name : this.issuerSlug}`,
            error,
        );
    });

2. Consider making BadgeResult.awardedCount a getter - this might be a better long-term approach as it reads the live value from the model rather than a snapshot, removing the
   staleness problem at the source. The ngOnChanges addition could then also be dropped:

export class BadgeResult {
	constructor(
		public badge: BadgeClass | PublicApiBadgeClass,
		public issuerName: string,
		public requestCount: number,
		private _awardedCount?: number,
	) {}

	get awardedCount(): number {
		if (this._awardedCount !== undefined) return this._awardedCount;
		return this.badge instanceof BadgeClass ? this.badge.recipientCount : 0;
	}
}

[fatimakay]

Hi @onemanwenttomow, thank you for reviewing. just updated the PR with your suggested changes!

[onemanwenttomow]

LGTM 🎉