Skip to content

chore(deps): migrate containers/image/v5 to go.podman.io/image/v5#895

Merged
frewilhelm merged 8 commits intoopen-component-model:mainfrom
frewilhelm:migrate-containers-image
Apr 21, 2026
Merged

chore(deps): migrate containers/image/v5 to go.podman.io/image/v5#895
frewilhelm merged 8 commits intoopen-component-model:mainfrom
frewilhelm:migrate-containers-image

Conversation

@frewilhelm
Copy link
Copy Markdown
Contributor

@frewilhelm frewilhelm commented Apr 13, 2026

What this PR does / why we need it

containers/image/v5 moved to a monorepo and our now available from go.podman.io/image/v5

Which issue(s) this PR is related to

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm requested a review from a team as a code owner April 13, 2026 14:14
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm force-pushed the migrate-containers-image branch from d506424 to 6cdc53e Compare April 13, 2026 14:52
morri-son
morri-son previously approved these changes Apr 13, 2026
@frewilhelm frewilhelm dismissed morri-son’s stale review April 13, 2026 15:16

test are failing

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
Copy link
Copy Markdown
Contributor Author

ocm.software/ocm@v0.39.0 still depends on the old github.com/containers/image/v5 and github.com/containers/storage module paths. Since our direct dependency go.podman.io/image/v5 pulls in go.podman.io/storage, the dependency graph ends up with two copies of the storage module under different paths — both containing the same unshare.c. On Linux, the linker sees the duplicate _containers_unshare symbol and fails.

ocm.software/ocm@v0.40.0-rc.1 has migrated to go.podman.io/image/v5 and go.podman.io/storage. With every dependency now using the new module paths, the old github.com/containers/image/v5 and github.com/containers/storage drop out of the graph entirely. One module path, one copy of the C code, no linker conflict.

Thats why it worked with ee65934

I will revert this and we will wait until ocm 0.40.0 is available

This reverts commit ee65934.

Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm self-assigned this Apr 20, 2026
@frewilhelm frewilhelm requested a review from morri-son April 21, 2026 12:47
@frewilhelm frewilhelm enabled auto-merge (squash) April 21, 2026 12:47
@frewilhelm frewilhelm merged commit b1cecfc into open-component-model:main Apr 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants