Add access to 'data' with indifferent access#5
Open
gavinlaking wants to merge 2 commits intoonthebeach:masterfrom
gavinlaking:add_data_with_indifferent_access
Open
Add access to 'data' with indifferent access#5gavinlaking wants to merge 2 commits intoonthebeach:masterfrom gavinlaking:add_data_with_indifferent_access
gavinlaking wants to merge 2 commits intoonthebeach:masterfrom
gavinlaking:add_data_with_indifferent_access
Conversation
Member
|
I think we should keep this one open until we find out if the change could end up reversing some of the performance improvements that were implemented in the previous release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Structural was changed to only allow access to keys via symbols, however there are projects using this library that access 'data' via 'string' keys. Since 'activesupport' is a dependency of this gem, we can leverage it to provide the desired behaviour.