Merged
Conversation
- Add scripts/update-test-coverage-doc.sh that runs tests with coverage, parses results (coverage %, pass/fail counts, per-file breakdown), and updates the auto-generated sections in cadence/tests/TEST_COVERAGE.md - Add .github/workflows/update_test_coverage.yml that triggers on push to main (i.e. after PR merge) and runs the update script - Add HTML comment markers in TEST_COVERAGE.md to delineate the auto-generated stats table and per-file results table from the manually curated analysis sections https://claude.ai/code/session_01McrgPdo8SVWxQQ63j9Esbb
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Member
|
Testing the linter in the latest version of Flow CLI (v2.15.1), it no longer crashes, so this PR should be good to go now |
ca067a0 to
72e36e8
Compare
6 tasks
Kay-Zee
reviewed
Mar 20, 2026
Member
Kay-Zee
left a comment
There was a problem hiding this comment.
There are 3 spots where we see unused vars that look like they should be used. The best guess here is that they're left overs from our refactors, but I need a bit of help confirming that.
turbolent
reviewed
Mar 20, 2026
turbolent
reviewed
Apr 13, 2026
|
|
||
| .PHONY: lint | ||
| lint: | ||
| find cadence/contracts -name "*.cdc" | xargs flow cadence lint \ |
Member
There was a problem hiding this comment.
@Kay-Zee why only lint contracts and not tests? 59af50b (this PR)
turbolent
approved these changes
Apr 13, 2026
jordanschalm
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make linttarget that runsflow cadence linton all.cdcfiles and fails if problems are foundTest plan
make lintlocally and verify it reports lint results🤖 Generated with Claude Code