fix(clippy): resolve pedantic and nursery warnings from Rust 1.95#121
Merged
JanZachmann merged 1 commit intoomnect:mainfrom Apr 22, 2026
Merged
Conversation
Address warnings surfaced by clippy under Rust 1.95: - collapsible match guards in reconnection.rs - sort_by_key with Reverse instead of sort_by closure - redundant clones in tests and device service client - String::new() instead of "".to_string() - items_after_statements refactors - pass-by-ref for generate_token; byte-literal and inline format args - u8::try_from for SESSION_KEY_LEN cast - implicit_clone fixes in network ini writing - unused headers collection removed in http_client test Annotate intentional exceptions: - #[allow(clippy::future_not_send)] on actix test helpers (actix uses Rc internally, so the future cannot be Send) - #[allow(clippy::await_holding_lock)] on firmware tests that intentionally serialize access to the data folder via std::sync::Mutex Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address warnings surfaced by clippy under Rust 1.95:
Annotate intentional exceptions: