fix(test): scope IP Address locators to active tab in multi-adapter tests#119
Merged
JanZachmann merged 1 commit intoomnect:mainfrom Apr 8, 2026
Merged
fix(test): scope IP Address locators to active tab in multi-adapter tests#119JanZachmann merged 1 commit intoomnect:mainfrom
JanZachmann merged 1 commit intoomnect:mainfrom
Conversation
…ests
Unscoped `page.getByRole('textbox', { name: /IP Address/i }).first()`
resolved to hidden eth0 input when wlan0/eth1 was the active tab,
causing fill() to fail with "element is not visible".
Scope all IP Address locators to `.v-window-item--active` to match
the correct input regardless of which tab is active.
Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.getByRole('textbox', { name: /IP Address/i }).first()locators to.v-window-item--activein multi-adapter e2e tests.first()resolved to the hidden eth0 input when wlan0/eth1 was the active tab, causingfill()to fail with "element is not visible"