fix(network): prevent path traversal in network interface name#118
Merged
JanZachmann merged 1 commit intoomnect:mainfrom Apr 8, 2026
Merged
fix(network): prevent path traversal in network interface name#118JanZachmann merged 1 commit intoomnect:mainfrom
JanZachmann merged 1 commit intoomnect:mainfrom
Conversation
Validate that the network interface name contains no path separators before using it in filesystem operations. Without this check, a crafted name like "../etc/foo" could write systemd-networkd config files outside the /network/ directory. Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
JanZachmann
force-pushed
the
fix/clippy-ci
branch
from
3549203 to
d7c41bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namefield against path traversal (../,/) before using it in filesystem path constructionPath::file_name()to ensure the name is a plain filename with no directory components.., and valid namesReason
The
network_config_file!macro builds paths like/network/10-{name}.networkdirectly from user input. A crafted name containing../could write systemd-networkd config files outside the/network/directory.