Draft
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JimmyShi22
reviewed
Feb 11, 2026
Contributor
JimmyShi22
left a comment
JimmyShi22
left a comment
There was a problem hiding this comment.
Code review of current HEAD.
Vui-Chee
added a commit
that referenced
this pull request
Mar 5, 2026
Port legacy data migration tool from PR #137 into existing bin/tools as a new 'migrate' subcommand. Migrates data from MDBX to RocksDB + static files for TransactionSenders, AccountChangeSets, Receipts, TransactionHashNumbers, AccountsHistory, and StoragesHistory tables. Key changes: - Add migrate.rs: core migration logic for static files and RocksDB - Add migrate_command.rs: CLI command with options (batch-size, skip-static-files, skip-rocksdb, keep-mdbx) - Add progress.rs: progress logging utilities - Update main.rs: add Migrate variant to Commands enum - Update Cargo.toml: add reth-provider/rocksdb, reth-stages/rocksdb, reth-static-file-types, reth-storage-api dependencies - Update .reth-dev.toml: add reth-stages and reth-static-file-types entries for local dev builds Co-Authored-By: vuicheesiew@gmail.com <vuicheesiew@gmail.com>
5 tasks
Vui-Chee
added a commit
that referenced
this pull request
Mar 13, 2026
Port the legacy data migration tool from PR #137 into the existing bin/tools crate as a new 'legacy-migrate' subcommand. Key changes: - Use workspace reth deps (paradigmxyz/reth v1.11.0) instead of pinned okx/reth git deps - Import chain spec from xlayer-chainspec crate instead of duplicating - Add reth-static-file-types to workspace dependencies - Adapt StorageSettings to use v2() API from upstream reth - Add reth-db, reth-node-builder, reth-primitives-traits deps to tools
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.