Redesign submission pipeline with per-client SubmissionIntent#30
Merged
Redesign submission pipeline with per-client SubmissionIntent#30
Conversation
added 3 commits
April 19, 2026 10:05
OnFinish stashes one intent per client; OnReplaySaved looks it up and dispatches. Map/steamid/name are captured at finish time so disconnects mid-save can't corrupt the submission.
Shavit passes oldtime=0 when there's no prior PB on the style. The old filter treated that as a non-PB and dropped the submission.
Handle WR istoolong (was leaving the intent stashed forever). Drop OnClientDisconnect's pending clear since the intent carries its own client data. Elevate unmapped-style drops to LogError. Restructure the replay-mode decision as a literal case ladder.
Member
Author
|
tested for once lol (hopefully im not missing cases :C) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OnFinish stashes one intent per client; OnReplaySaved looks it up and
dispatches. Map/steamid/name are captured at finish time so disconnects
mid-save can't corrupt the submission.