refactor(rpc): move server lifecycle into rpc library#15217
Merged
Conversation
rgrinberg
force-pushed
the
push-pxkunowqlmzk
branch
5 times, most recently
from
c586582 to
a878923
Compare
Move generic RPC server run, ready, and stop handling from dune_rpc_impl into Rpc.Server.Lifecycle. Keep Dune-specific startup-failure handling and the status-line wrapper in dune_rpc_impl. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-pxkunowqlmzk
branch
from
a878923 to
3ecc143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move generic RPC server run, ready, and stop handling from dune_rpc_impl into Rpc.Server.Lifecycle. Keep Dune-specific startup-failure handling and the status-line wrapper in dune_rpc_impl.