fix(watch): complete RPC builds independently#15191
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
rgrinberg
force-pushed
the
push-puokwtospnyx
branch
4 times, most recently
from
353f381 to
e2a2bdf
Compare
Introduce build requests with hidden completion ivars in the build system. The watch build loop can still batch RPC build requests together, but each request now reports success as soon as its own action builder and per-request finalization complete instead of waiting for the entire batch. Complete any unfinished RPC requests with the batch outcome when a build iteration ends, so requests cancelled by --stop-on-first-error do not hang. Update the concurrent RPC build cram test to expect the fast request to finish before the slow target is released. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> refactor(watch): narrow RPC request completion hook Signed-off-by: Rudi Grinberg <me@rgrinberg.com> refactor(watch): use input generation for RPC completion Signed-off-by: Rudi Grinberg <me@rgrinberg.com> fix(watch): defer diff-promotion output and finish to batch end Per-request finalization now only saves the diff-promotion database without promoting files, so promotion output stays ordered after diff and error messages. When per-request completion triggers a restart signal but all RPC requests have already finished, treat the iteration as Done so that the watch status line is still emitted. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> refactor(watch): split RPC request checkpointing from completion Checkpoint request side effects before completing RPC requests, but keep build-wide diff-promotion finalization at the end of the build iteration. Defer request completion under --auto-promote after a checkpoint saves diff promotions, so watch mode can still restart after the final auto-promotion. This restores ordinary auto-promote output ordering while keeping saved promotions visible to RPC promotion requests. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-puokwtospnyx
branch
from
e2a2bdf to
f1a68d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce build requests with hidden completion ivars in the build system. The watch build loop can still batch RPC build requests together, but each request now reports success as soon as its own action builder completes instead of waiting for the entire batch.
Update the concurrent RPC build cram test to expect the fast request to finish before the slow target is released.