Update orderless-escapable-split-on-space to support other characters#197
Open
dadinn wants to merge 1 commit intooantolin:masterfrom
Open
Update orderless-escapable-split-on-space to support other characters#197dadinn wants to merge 1 commit intooantolin:masterfrom
dadinn wants to merge 1 commit intooantolin:masterfrom
Conversation
Allow customizing the escapable component separator character to be other than just a space.
Collaborator
|
Thanks for the proposal. I am a bit skeptical about this addition, since I find it a bit too special. I am unsure if many users will need it, since it hasn't come up in discussion yet, except the linked issue. One can always write a custom splitting function if really needed. Can you show a real use case where we need this? In Corfu and in minibuffer completion in general the space separator works well. |
Collaborator
|
It seems @oantolin had already rejected this feature request in #102 (comment). I think this still holds without further evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows customising the escapable component separator character to be other than just a space. This feature was originally requested/discussed here.
Introduces a new customisable variable
orderless-escapable-separator, which allows any character to be used as separator, not just the default space character (to be backwards compatible).Example with corfu:

Example with vertico:

The above examples use the following
orderless-matching-styles: