[#41]: Streamline signing for CoRIM protected header + test both routes#43
Draft
iadgovuser62 wants to merge 1 commit intomainfrom
Draft
[#41]: Streamline signing for CoRIM protected header + test both routes#43iadgovuser62 wants to merge 1 commit intomainfrom
iadgovuser62 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 2 typical routes of actions for RIMs in this tool:
Create(unsigned) >Sign>VerifyCreate(signed) >VerifyCurrently for CoRIM, these 2 routes differ greatly and the codeflow is different for
Create(unsigned) versusCreate(signed). Specifically, theCreate(signed) code adds fields to the protected header (i.e. corim-meta-map) which the current IETF spec requires (see section 4.2.1). Objects with these additions from theCreate(signed) route are failing to verify.This PR is intended to:
Create(unsigned) andCreate(signed), while maintaining additional fields for CoRIM (i.e. corim-meta-map)corim_comid_tests.shscript to test both routesResolves #41