Skip to content

Fix tables showing incorrect amount of pages, and some other table issues#1198

Open
juhanikat wants to merge 6 commits into
mainfrom
table-pagination-issue
Open

Fix tables showing incorrect amount of pages, and some other table issues#1198
juhanikat wants to merge 6 commits into
mainfrom
table-pagination-issue

Conversation

@juhanikat

@juhanikat juhanikat commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Fixes #817. Also fixes:

  • Occurences table navigating back to first page as soon as user tries to go to another page
  • console error related to the menu bar of the Occurences table
  • rerender loop in TableView caused by a dependency inside a useEffect.

@juhanikat juhanikat force-pushed the table-pagination-issue branch from ac64052 to 2c9f7f3 Compare June 15, 2026 12:39
@juhanikat juhanikat changed the title fix pagination showing incorrect page amount when filters are applied Fix tables showing incorrect amount of pages, and some other table issues Jun 15, 2026
@juhanikat juhanikat requested review from Copilot and karilint June 15, 2026 12:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses several pagination/state issues in the shared TableView used across the frontend, primarily fixing incorrect page counts (Issue #817) and stabilizing server-side pagination behavior for the occurrences/cross-search table.

Changes:

  • Adjusts TableView pagination behavior by only providing rowCount for server-side pagination and disabling automatic page-index resets when server-side pagination is enabled.
  • Introduces rowCount state updates based on server-side results (full_count) and resets pagination when filters/sorting change.
  • Updates CrossSearch export menu rendering to avoid a React fragment inside an MUI Menu.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
frontend/src/components/TableView/TableView.tsx Reworks pagination + row counting logic to fix incorrect page counts and server-side paging resets.
frontend/src/components/CrossSearch/CrossSearchTable.tsx Changes the extra export menu items wrapper used inside the table export menu.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/src/components/TableView/TableView.tsx
Comment thread frontend/src/components/TableView/TableView.tsx Outdated
Comment thread frontend/src/components/TableView/TableView.tsx Outdated
Comment thread frontend/src/components/CrossSearch/CrossSearchTable.tsx
@juhanikat juhanikat force-pushed the table-pagination-issue branch from a14e2e6 to d7ec15b Compare June 16, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants