Fix tables showing incorrect amount of pages, and some other table issues#1198
Open
juhanikat wants to merge 6 commits into
Open
Fix tables showing incorrect amount of pages, and some other table issues#1198juhanikat wants to merge 6 commits into
juhanikat wants to merge 6 commits into
Conversation
ac64052 to
2c9f7f3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses several pagination/state issues in the shared TableView used across the frontend, primarily fixing incorrect page counts (Issue #817) and stabilizing server-side pagination behavior for the occurrences/cross-search table.
Changes:
- Adjusts
TableViewpagination behavior by only providingrowCountfor server-side pagination and disabling automatic page-index resets when server-side pagination is enabled. - Introduces
rowCountstate updates based on server-side results (full_count) and resets pagination when filters/sorting change. - Updates CrossSearch export menu rendering to avoid a React fragment inside an MUI
Menu.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
frontend/src/components/TableView/TableView.tsx |
Reworks pagination + row counting logic to fix incorrect page counts and server-side paging resets. |
frontend/src/components/CrossSearch/CrossSearchTable.tsx |
Changes the extra export menu items wrapper used inside the table export menu. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e numbers accurate in all tables
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
a14e2e6 to
d7ec15b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #817. Also fixes: