test: fix build on 32bit platforms#500
Conversation
siretart
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT and
toddysm
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 36 36
Lines 3358 3358
=======================================
Hits 2736 2736
Misses 480 480
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shizhMSFT
changed the title
|
@siretart Thanks for adding 32bit arch support. Would you mind sharing your use case? I am curious on your scenario. |
|
I'm packaging this library for Debian, and we test it on like a dozen different architectures. The use case can be described as having the notation cli binary prebuilt for as many architectures as possible so that it can be made available a regular Debian package and available via |
|
This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days. |
|
This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days. |
|
sorry for the delay. I've now signed this commit with the gpg key I'm using to sign my packages in Debian. Let me know if that is acceptable |
|
This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days. |
|
anything else missing? I believe this can be cherry-picked |
|
This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days. |
Reproduce with: $ GOARCH=386 go test -v github.com/notaryproject/notation-go ./notation_test.go:763:26: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in struct literal (overflows) FAIL github.com/notaryproject/notation-go [build failed] FAIL Signed-off-by: Reinhard Tartler <siretart@tauware.de>
siretart
force-pushed
the
32bit-buildfix
branch
from
69cef69 to
dcf20b7
Compare
|
@siretart Could you sign your commits so that we can merge this PR? |
|
As far as I can tell https://patch-diff.githubusercontent.com/raw/notaryproject/notation-go/pull/500.patch already contains a proper "signed-off-by" line. Maybe you mean something else that I might be missing? |
|
As far as I can tell, the current patch already contains a proper "Signed-off-by" line. Check here: https://patch-diff.githubusercontent.com/raw/notaryproject/notation-go/pull/500.patch Maybe I'm missing something else? Please clarify what you mean exactly. |
|
This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days. |
|
Hi! Could someone cherry-pick and merge this? I can confirm that it solves a i386 build error: https://salsa.debian.org/jas/golang-github-notaryproject-notation-go/-/jobs/8531986 Thanks, |
|
@siretart can you please follow the guide to sign it? It looks like your git commit is not signed correctly. The right commit should have this signal Hi @jas4711 , would you mind opening a new PR with a signed commit if this is required for your scenario? This is a tiny change so it can be merged very quick. |
|
Closing this as per the comments above and #563 superseding this one. |
7 participants
Reproduce with:
$ GOARCH=386 go test -v github.com/notaryproject/notation-go
./notation_test.go:763:26: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in struct literal (overflows)
FAIL github.com/notaryproject/notation-go [build failed]
FAIL
Signed-off-by: Reinhard Tartler siretart@gmail.com