hotfix: this pr hotfixes a few styles#8608
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8608 +/- ##
==========================================
- Coverage 75.03% 75.02% -0.02%
==========================================
Files 103 103
Lines 9062 9062
Branches 312 312
==========================================
- Hits 6800 6799 -1
- Misses 2260 2261 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR is a hotfix that addresses style and layout issues at certain breakpoints, particularly fixing an overflow problem caused by z-index conflicts with the Sidebar component. It also updates the codebase to use Tailwind CSS v4's new data attribute syntax.
Changes:
- Updated data attribute syntax from Tailwind v3 format (
data-[attribute]) to v4 format (data-attribute) - Fixed sidebar overflow issue by adding
z-0to explicitly set its stacking context - Adjusted breakpoints from 670px to 890px for better responsive behavior
- Bumped package version to 1.5.10
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ui-components/src/Containers/Sidebar/index.module.css | Added z-0 to sidebar wrapper to fix overflow issues |
| packages/ui-components/src/Common/Select/index.module.css | Updated data attribute syntax to Tailwind v4 format and increased dropdown z-index from z-99 to z-999 |
| packages/ui-components/package.json | Bumped version from 1.5.9 to 1.5.10 |
| apps/site/components/withMetaBar.tsx | Adjusted responsive breakpoints from 670px to 890px for mobile and tablet resolutions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Build Size ComparisonSummary
Changes➕ Added Assets (2)
➖ Removed Assets (2)
|
|
agree broken, not waiting the 2 day here |
2 participants
This PR is a hot-fix for certain styles/breakpoints, including the overflow caused due to z-index on Sidebar as shown below (happens only on certain breakpoints)