fix(translation): don't translate OpenJS Foundation#8129
fix(translation): don't translate OpenJS Foundation#8129avivkeller wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the translation of "OpenJS Foundation" by ensuring it remains untranslated across all locales. The organization name should be kept as a proper noun in its original English form rather than being translated to local languages.
- Removed translated versions of "OpenJS Foundation" from all locale files
- Updated the navigation type system to support both translatable labels and static text
- Modified the footer component to handle both translatable and non-translatable text
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/i18n/src/locales/*.json | Removed translated "openJSFoundation" entries from Ukrainian, Romanian, Japanese, French, and English locale files |
| apps/site/types/navigation.ts | Updated FooterConfig type to support optional label and text properties |
| apps/site/navigation.json | Changed OpenJS Foundation link from translatable label to static text |
| apps/site/components/withFooter.tsx | Updated footer rendering logic to handle both translatable labels and static text |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8129 +/- ##
==========================================
+ Coverage 76.56% 76.60% +0.04%
==========================================
Files 115 115
Lines 9595 9595
Branches 322 321 -1
==========================================
+ Hits 7346 7350 +4
+ Misses 2248 2244 -4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
In #8072 it was mentioned that at least in Chinese and Japanese, 'Foundation' would be expected to be translated so I'm not sure this is the answer? |
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
blocking per resolution of conversation with Open JS
|
@bmuenzenmeyer did that conversation happen? |
|
I sent the email and it was affirmed as received and under review. I'm awaiting a response. |
|
Any updates? |
Not yet. I sent another ping to Robin and Legal |
Fixes #8072