Fix git node release --prepare update proposal workflow#882
Merged
aduh95 merged 1 commit intonodejs:mainfrom Mar 28, 2025
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ruyadorno
force-pushed
the
fix-git-node-prepare-release-update-proposal
branch
from
fec7e76 to
38ad9c8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
reviewed
Jan 6, 2025
In `git node release --prepare` when checking out a new proposal branch make sure it's also possible to update an already existing branch of that same name instead of failing and terminating the automation.
ruyadorno
force-pushed
the
fix-git-node-prepare-release-update-proposal
branch
from
38ad9c8 to
0a14955
Compare
RafaelGSS
approved these changes
Jan 6, 2025
aduh95
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for updating a proposal once the proposal branch has already been created, PR opened, e.g: