Conversation
|
CC @richardlau @nodejs/node-core-utils |
Codecov Report
@@ Coverage Diff @@
## main #642 +/- ##
==========================================
+ Coverage 84.09% 84.24% +0.14%
==========================================
Files 37 37
Lines 4074 4138 +64
==========================================
+ Hits 3426 3486 +60
- Misses 648 652 +4
Continue to review full report at Codecov.
|
ncu-cu resume <prid> commandncu-ci resume <prid> command
6957918 to
547c5a8
Compare
acfb36b to
ed06933
Compare
|
So I tried this branch and got the following errors: $ ./bin/ncu-ci.js resume https://github.com/nodejs/node/pull/43919
✖ GitHub repository is missing, please set it via ncu-config or pass it via the --repo option
✖ GitHub owner is missing, please set it via ncu-config or pass it via the --owner option
$ ./bin/ncu-ci.js resume --repo node --owner nodejs https://github.com/nodejs/node/pull/43919
Error: [undefined] GraphQL request Error: Variable $prid of type Int! was provided invalid value
at Request.query (file://…/lib/request.js:112:19)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Request.gql (file://…/lib/request.js:69:22)
at async PRData.getPR (file://…/lib/pr_data.js:80:20)
at async Promise.all (index 0)
at async JobParser.fromPRId (file://…/lib/ci/ci_type_parser.js:194:3)
at async ResumePRJobCommand.start (file://…/bin/ncu-ci.js:319:20) {
data: { variables: { prid: NaN, owner: 'nodejs', repo: 'node' } }
}The following works though, and produces the expected result (nodejs/node#43919 (comment)): $ ./bin/ncu-ci.js resume --repo node --owner nodejs 43919
✔ Jenkins credentials valid
✔ Build data downloaded
✔ PR CI job successfully resumed |
|
@aduh95 that is expected the |
|
This should not say |
|
There are a few conflicts to address here. |
refs: nodejs/node#40817
refs: nodejs/node#42125
I was able to test most of the flow except for the actual resume part - since my user dose not have resume permissions
, but this resume url worked on a local jenkins I use - if any reviewer can check the entire flow for me it will be great