Conversation
PeterDaveHello
left a comment
There was a problem hiding this comment.
Maybe we should extend jobs.build.if to ensure the workflow only runs on main when triggered via workflow_dispatch?
This helps avoid running repo scripts + secrets from a non-main branch.
Currently it's if: github.repository_owner == 'nodejs', we could change it to:
jobs:
build:
if: github.repository_owner == 'nodejs' && github.ref_name == 'main'
This comment was marked as outdated.
This comment was marked as outdated.
|
@nschonni You're right that |
|
By the way, with workflow_dispatch added, this workflow would also be runnable manually alongside the existing schedule. Adding concurrency could help prevent overlapping runs racing on the same updates (e.g., duplicate PRs or conflicting pushes). concurrency:
group: automatic-updates
cancel-in-progress: false |
Description
Allowing us to manually trigger a run of the update job
Motivation and Context
Staring at

due to #2341 (comment)
Testing Details
Example Output(if appropriate)
Types of changes
Checklist