Make it more obvious how to run a node image as non-root#2288
Open
rugk wants to merge 2 commits intonodejs:mainfrom
Open
Make it more obvious how to run a node image as non-root#2288rugk wants to merge 2 commits intonodejs:mainfrom
rugk wants to merge 2 commits intonodejs:mainfrom
Conversation
Fixes nodejs#2287 IMHO, you may also link the best practices on https://hub.docker.com/_/node/#how-to-use-this-image directly, to save some more clicks and hopefully make more people find the information about non-root users.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README to better highlight security best practices, specifically drawing attention to the non-root user guidance in the Best Practices documentation.
- Adds a security-focused note to make non-root user information more discoverable
- Links directly to the specific section about non-root users in the best practices guide
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This IMHO highlights a critical part.
Motivation and Context
Fixes #2287 (see there for more reasoning)
IMHO, you may also link the best practices on https://hub.docker.com/_/node/#how-to-use-this-image directly, to save some more clicks and hopefully make more people find the information about non-root users.
I personally have not found that information as I searched for
beston docker-hub and forrootthere and this Readme. (I missed searching forbestagain so maybe this helps.)Testing Details
Example Output(if appropriate)
Types of changes
Checklist
My change requires a change to the documentation.