Open
Conversation
Contributor
We're unlikely to do that, as we want our official binaries to be downloaded from our official website. |
aduh95
commented
Aug 19, 2024
arcanis
requested changes
Aug 19, 2024
Contributor
arcanis
left a comment
There was a problem hiding this comment.
Marking request changes just to be sure this doesn't land before we implement signing in Yarn (which is in our plans, but I'm in paternity leave at the moment).
Member
|
@arcanis I'm glad to hear that signatures are planned for yarn. what's your timeline to add said support? September/October? |
tiaraton
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the most common use case where a Corepack user interacts with an already-setup-for-Corepack project, this PR doesn't change anything, the project would have a
"packageManager"field that includes a hash to validate the download.However, for cases when there are no hash defined there or in the CLI command (
corepack yarn@3.x …/corepack up/corepack use yarn@3.x), we need another way to validate the download. For downloads from the npm registry, we verify using the ECDSA signature provided in the package metadata. For package manager that are not downloaded from the npm registry (i.e. Yarn Berry), the download is only protected by TLS, which is pretty good, but not as good.This change is going to be disruptive to Yarn Berry users. I think the Yarn team can mitigate by either:
Fixes: #495