Open
Conversation
SaadAssaf
force-pushed
the
nctl_PreventSuccessMessage
branch
from
6ac183c to
72440cf
Compare
thde
reviewed
May 4, 2026
Checked if update flags are provided in configCmd. if no flags are used, the command now return an error instead of a success message.
SaadAssaf
force-pushed
the
nctl_PreventSuccessMessage
branch
from
d1a0217 to
0499a9b
Compare
thde
reviewed
May 8, 2026
| BuildContext *string `name:"dockerfile-build-context" help:"${app_dockerfile_build_context_help}" placeholder:"."` | ||
| } | ||
|
|
||
| func (cmd *applicationCmd) changesGiven() bool { |
Member
There was a problem hiding this comment.
So I see two patterns:
applyUpdateswith returning abool.- A separate function
changesGivenreturning a bool.
Is there any reason why we have those two patterns and why it is not done the same way everywhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.