Skip to content

feat: add HTTP Digest authentication support for WebDAV backend#287

Merged
miaulalala merged 1 commit intomasterfrom
feat/webdav-digest-auth
Apr 16, 2026
Merged

feat: add HTTP Digest authentication support for WebDAV backend#287
miaulalala merged 1 commit intomasterfrom
feat/webdav-digest-auth

Conversation

@miaulalala
Copy link
Copy Markdown
Collaborator

@miaulalala miaulalala commented Mar 25, 2026

Implements the feature requested in PR #225 / proposed in PR #227. Adds an optional second constructor argument ('basic' or 'digest', defaulting to 'basic' for full backward compatibility).

@miaulalala miaulalala self-assigned this Mar 25, 2026
@miaulalala miaulalala added this to the v4.1.0 milestone Mar 25, 2026
@miaulalala miaulalala requested a review from Copilot April 16, 2026 15:35

This comment was marked as outdated.

Sign in to view

@miaulalala miaulalala requested a review from Copilot April 16, 2026 17:49
@miaulalala miaulalala force-pushed the feat/webdav-digest-auth branch from b1889e9 to 9e355ec Compare April 16, 2026 17:50

This comment was marked as outdated.

Sign in to view

@miaulalala miaulalala force-pushed the feat/webdav-digest-auth branch from 9e355ec to e70caa6 Compare April 16, 2026 18:08
@miaulalala miaulalala requested a review from Copilot April 16, 2026 18:10
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/WebDavAuth.php
Comment thread lib/WebDavAuth.php
Comment thread lib/WebDavAuth.php
@miaulalala miaulalala force-pushed the feat/webdav-digest-auth branch from e70caa6 to 3cd0d1b Compare April 16, 2026 18:18
@miaulalala miaulalala requested a review from Copilot April 16, 2026 18:18
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/WebDavAuth.php Outdated
Comment thread lib/WebDavAuth.php Outdated
@miaulalala miaulalala force-pushed the feat/webdav-digest-auth branch from 3cd0d1b to 6ccef8f Compare April 16, 2026 18:38
@miaulalala miaulalala requested a review from Copilot April 16, 2026 18:39
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/WebDavAuth.php Outdated
Comment thread lib/WebDavAuth.php
Comment thread lib/WebDavAuth.php Outdated
Comment thread lib/WebDavAuth.php
@miaulalala miaulalala force-pushed the feat/webdav-digest-auth branch from 6ccef8f to e697b67 Compare April 16, 2026 20:59
@miaulalala miaulalala requested a review from Copilot April 16, 2026 21:00
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/WebDavAuth.php Outdated
Comment thread tests/unit/WebDavAuthTest.php Outdated
@miaulalala miaulalala force-pushed the feat/webdav-digest-auth branch from e697b67 to 3380114 Compare April 16, 2026 21:25
@miaulalala miaulalala requested a review from Copilot April 16, 2026 21:32
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/unit/WebDavAuthTest.php Outdated
Comment thread lib/WebDavAuth.php
Comment thread lib/WebDavAuth.php Outdated
Comment thread lib/WebDavAuth.php
Comment thread lib/WebDavAuth.php
@miaulalala miaulalala force-pushed the feat/webdav-digest-auth branch from 3380114 to b3ecc52 Compare April 16, 2026 21:38
@miaulalala miaulalala requested a review from Copilot April 16, 2026 21:40
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/WebDavAuth.php
@miaulalala miaulalala force-pushed the feat/webdav-digest-auth branch from b3ecc52 to 01fc8bb Compare April 16, 2026 21:46
@miaulalala miaulalala requested a review from Copilot April 16, 2026 21:47
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/WebDavAuth.php Outdated
@miaulalala miaulalala force-pushed the feat/webdav-digest-auth branch from 01fc8bb to c62ff8a Compare April 16, 2026 22:01
@miaulalala miaulalala requested a review from Copilot April 16, 2026 22:03
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/WebDavAuth.php Outdated
@miaulalala
feat: add HTTP Digest authentication support for WebDAV backend
dbe13f5 
Implements the feature requested in PR #225 / proposed in PR #227.
Adds an optional second constructor argument  ('basic' or 'digest', defaulting to 'basic' for full backward compatibility).

AI-assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the feat/webdav-digest-auth branch from c62ff8a to dbe13f5 Compare April 16, 2026 22:09
@miaulalala miaulalala merged commit cc247f2 into master Apr 16, 2026
38 checks passed
@miaulalala miaulalala deleted the feat/webdav-digest-auth branch April 16, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

@miaulalala miaulalala

Labels

3. to review

Projects

None yet

Milestone

v4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@miaulalala @AndyScherzinger