fix: Fix permission issue when uploading a chunked file#59654
Open
CarlSchwan wants to merge 1 commit intomasterfrom
Open
fix: Fix permission issue when uploading a chunked file#59654CarlSchwan wants to merge 1 commit intomasterfrom
CarlSchwan wants to merge 1 commit intomasterfrom
Conversation
CarlSchwan
requested review from
Altahrim,
icewind1991,
leftybournes and
nfebe
and removed request for
a team
CarlSchwan
force-pushed
the
carl/permission-upload
branch
3 times, most recently
from
53e9c32 to
f2ce921
Compare
susnux
approved these changes
Apr 15, 2026
Follow up from #59511 Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/permission-upload
branch
from
f2ce921 to
d10cf97
Compare
provokateurin
approved these changes
Apr 15, 2026
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
8 tasks
icewind1991
reviewed
Apr 15, 2026
|
|
||
| public function rename($source, $target): bool { | ||
| if (!$this->isUpdatable($source)) { | ||
| if (!$this->isDeletable($source)) { |
Member
There was a problem hiding this comment.
That is not correct, see #57374 for some details around rename permissions
Member
Author
There was a problem hiding this comment.
Suggested change
| if (!$this->isDeletable($source)) { | |
| if (!($this->isDeletable($source) || $this->isUpdatable($source))) { |
Would this work?
Member
Author
There was a problem hiding this comment.
Or we can add Constants::PERMISSION_UPDATABLE in apps/dav/appinfo/v2/publicremote.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #59511
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)