perf: swap around root_id and mount_path_hash in index#59652
Open
icewind1991 wants to merge 1 commit intomasterfrom
Open
perf: swap around root_id and mount_path_hash in index#59652icewind1991 wants to merge 1 commit intomasterfrom
icewind1991 wants to merge 1 commit intomasterfrom
Conversation
icewind1991
requested review from
Altahrim,
ArtificialOwl,
salmart-dev and
sorbaugh
and removed request for
a team
icewind1991
force-pushed
the
mounts-index-swap-path_root
branch
from
0dcb63a to
13ce0ad
Compare
provokateurin
requested changes
Apr 15, 2026
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
mounts-index-swap-path_root
branch
from
13ce0ad to
1362b2f
Compare
provokateurin
approved these changes
Apr 15, 2026
CarlSchwan
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently no place (outside of tests) where we filter by just the user and root_id, but there are places (and more with #59649) where we filter by just user and mountpoint.
By moving the two columns around in the index we ensure that the index can be better used for those queries.