feat(settings): unified search for accounts and groups#59626
Open
pringelmann wants to merge 5 commits intomasterfrom
Open
feat(settings): unified search for accounts and groups#59626pringelmann wants to merge 5 commits intomasterfrom
pringelmann wants to merge 5 commits intomasterfrom
Conversation
pringelmann
force-pushed
the
feat/59166/unified-user-group-search
branch
2 times, most recently
from
b5c2b9e to
e107c10
Compare
Contributor
Author
|
/compile |
pringelmann
requested review from
nfebe,
sorbaugh and
szaimen
and removed request for
a team
pringelmann
added
3. to review
pringelmann
force-pushed
the
feat/59166/unified-user-group-search
branch
from
b14bc64 to
c672b9a
Compare
Contributor
Author
|
/compile amend / |
artonge
reviewed
Apr 14, 2026
jancborchardt
approved these changes
Apr 15, 2026
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Design-wise this looks nice, filtering both users and groups at the same time. :)
Replace the unified search event bus subscription and the separate group sidebar search with a single input in the account management navigation. The query is shared via Vuex so UserList and AppNavigationGroupList react to the same state. Part of #53862 Fixes #59166 Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
-e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
-e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
feat/59166/unified-user-group-search
branch
from
37288e5 to
47ddd2c
Compare
artonge
reviewed
Apr 16, 2026
-e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
-e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
artonge
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #53862. Replaces the two separate search mechanisms in account management (global unified search bar for users, sidebar input for groups) with a single search field in the account management sidebar. Typing dispatches to both the users and groups API.
The search query lives in the Vuex store so
UserListandAppNavigationGroupListcan react to the same state without needing a shared parent component.Behaviour change
The
UserListno longer subscribes tonextcloud:unified-search.search, so the global top-bar search no longer filters the account list.Keeping both in sync both ways turned out messy (clearing one didn't clear the other), so the dedicated sidebar input is now the single entry point for this page. Happy to revisit if reviewers disagree.Ctrl+F now brings the new input into focus instead of the global search.
Scope
MVP only: filters users and groups by name. Both APIs already support
?search=, so no backend changes.Matching groups by member name (e.g. searching "alice" surfaces the groups alice belongs to) is a nice-to-have and deferred as a follow-up.
Checklist
3. to review, feature component)stable32)