Skip to content

[stable33] fix(settings): hide list of webauthn devices if empty#59491

Open
backportbot[bot] wants to merge 2 commits intostable33from
backport/59423/stable33
Open

[stable33] fix(settings): hide list of webauthn devices if empty#59491
backportbot[bot] wants to merge 2 commits intostable33from
backport/59423/stable33

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot bot commented Apr 7, 2026

Backport of #59423

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

- resolves #59339

If there are no devices the list would be empty.
This is invalid for accessibility, as every list needs at least one
listitem.
Ref: https://www.w3.org/TR/wai-aria-1.2/#mustContain

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/59423/stable33 branch from 30420db to 64e017c Compare April 16, 2026 13:17
@susnux susnux marked this pull request as ready for review April 16, 2026 13:18
@susnux susnux requested a review from a team as a code owner April 16, 2026 13:18
@susnux susnux requested review from nfebe and sorbaugh and removed request for a team April 16, 2026 13:18
@susnux
Copy link
Copy Markdown
Contributor

susnux commented Apr 16, 2026

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants