-
Notifications
You must be signed in to change notification settings - Fork 39
feat(photos): Add Google Photos import via Picker API #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
98dad31
feat(photos): replace legacy Photos API with Google Photos Picker API
AhsanIsEpic 095c532
chore: bump version to 4.3.2
AhsanIsEpic 61f4484
chore: revert version to 4.3.1
AhsanIsEpic f65727d
fix(photos): address remaining Copilot review comments
AhsanIsEpic 8f67c61
fix(photos): fix polling interval leak and progress text pluralization
AhsanIsEpic 75caf00
fix(photos): address Copilot review comments round 3
AhsanIsEpic 2e3b212
fix(photos): address Copilot review comments round 4
AhsanIsEpic 5e30d29
refactor(photos): replace ID-map dedup with filesystem existence check
AhsanIsEpic e6f362d
refactor(photos): use file metadata for cross-session dedup
AhsanIsEpic 5ec5dd0
fix(photos): address Copilot review comments round 5
AhsanIsEpic a20aec7
feat(photos): support queueing multiple picker sessions
AhsanIsEpic 98496e9
fix(photos): rename cancel buttons and fix picker button gap
AhsanIsEpic f10c644
fix(photos): avoid transient importing_photos=0 on queue transition; …
AhsanIsEpic b033102
fix(photos): address Copilot review comments round 6
AhsanIsEpic 4ae52bf
fix(photos): address Copilot review comments round 7
AhsanIsEpic e82ce7f
fix(photos): address Copilot review comments round 8
AhsanIsEpic f93117a
fix(photos): clear picker session queue and page token on import error
AhsanIsEpic 980221a
fix(photos): address maintainer review comments
AhsanIsEpic 30edd1f
fix(photos): correct copyright year to 2026
AhsanIsEpic 3ab61e8
fix(photos): address Copilot review comments round 9
AhsanIsEpic 037d5a2
fix(photos): validate queue json_decode result with is_array() check
AhsanIsEpic 347cb69
fix: address Copilot review comments round 10
AhsanIsEpic 5eefc37
fix: address Copilot review comments round 11
AhsanIsEpic 6e0c8cf
fix: address maintainer review comments (lukasdotcom) round 1
AhsanIsEpic 3c524d9
fix: wrap cleanup delete/unlock calls in try/catch in downloadAndSave…
AhsanIsEpic df80076
Address comments
AhsanIsEpic 2c794e4
README changes
AhsanIsEpic b98709a
Resolve minor comments
AhsanIsEpic 80cd6ea
reverted the popup flow back to the older opener-based behavior
AhsanIsEpic ba86c4e
Remove correct CSS
AhsanIsEpic b232363
Remove popup focus guard
AhsanIsEpic 9437041
Revert popup handler changes
AhsanIsEpic ff6ddbe
Simplify finished photo import flow
AhsanIsEpic 269cb43
Update src/components/PersonalSettings.vue
AhsanIsEpic 198c264
removed the “restart polling” block from onImportPhotos().catch(...)
AhsanIsEpic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Nextcloud - integration_google | ||
| * | ||
| * This file is licensed under the Affero General Public License version 3 or | ||
| * later. See the COPYING file. | ||
| * | ||
| * @author Ahsan Ahmed | ||
| * @copyright Nextcloud GmbH and Nextcloud contributors 2026 | ||
| */ | ||
|
|
||
| namespace OCA\Google\BackgroundJob; | ||
|
|
||
| use OCA\Google\Service\GooglePhotosAPIService; | ||
| use OCP\AppFramework\Utility\ITimeFactory; | ||
| use OCP\BackgroundJob\QueuedJob; | ||
|
|
||
| /** | ||
| * A QueuedJob to partially import google photos and launch following job | ||
| */ | ||
| class ImportPhotosJob extends QueuedJob { | ||
|
|
||
| public function __construct( | ||
| ITimeFactory $timeFactory, | ||
| private GooglePhotosAPIService $service, | ||
| ) { | ||
| parent::__construct($timeFactory); | ||
| } | ||
|
|
||
| /** | ||
| * @param array{user_id:string} $argument | ||
| */ | ||
| public function run($argument) { | ||
| $userId = $argument['user_id']; | ||
| $this->service->importPhotosJob($userId); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.