Fix Promise.finally() to await returned thenables per ES2018 semantics

[Copilot]

finally() in the base promise implementation did not wait for promises returned by the callback, allowing chains to continue before async cleanup completed. This diverged from ES2018 behavior and could cause ordering bugs in cleanup paths.

• finally() now composes with returned thenables

  • Updated /home/runner/work/ts-async/ts-async/lib/src/promise/base.ts so both fulfillment and rejection paths route through doAwait(onFinally(), ...).
  • Behavior now matches spec expectations:
    • wait if onFinally returns a thenable
    • preserve original value/reason when onFinally resolves
    • reject with onFinally’s error if it rejects

• Added focused behavioral coverage for async finally

  • Extended /home/runner/work/ts-async/ts-async/lib/test/src/promise/use.await.test.ts with cases for:
    • resolve path waits for async finally
    • reject path waits for async finally
    • original rejection is preserved when finally resolves
    • finally rejection takes precedence over original rejection

// base.ts (conceptual change)
thenFinally = (value) =>
  doAwait(onFinally && onFinally(), () => value);

catchFinally = (reason) =>
  doAwait(onFinally && onFinally(), () => { throw reason; });

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• accounts.google.com
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4679 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-55967824 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10962815086647567136,14307033486024915863,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11551347510497868719,13263738053133585942,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome --user-data-dir=/tmp/karma-55967824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --disable-web-security --disable-dev-shm-usage http://localhost:9876/?id=55967824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4913 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-39444664 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5706315277108938739,13159022639949838835,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2159818381503667631,12417947849844884018,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
• android.clients.google.com
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4679 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-55967824 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10962815086647567136,14307033486024915863,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11551347510497868719,13263738053133585942,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome --user-data-dir=/tmp/karma-55967824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --disable-web-security --disable-dev-shm-usage http://localhost:9876/?id=55967824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4913 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-39444664 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5706315277108938739,13159022639949838835,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2159818381503667631,12417947849844884018,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
• clients2.google.com
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4679 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-55967824 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10962815086647567136,14307033486024915863,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11551347510497868719,13263738053133585942,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome --user-data-dir=/tmp/karma-55967824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --disable-web-security --disable-dev-shm-usage http://localhost:9876/?id=55967824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4913 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-39444664 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5706315277108938739,13159022639949838835,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2159818381503667631,12417947849844884018,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
• redirector.gvt1.com
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4679 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-55967824 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10962815086647567136,14307033486024915863,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11551347510497868719,13263738053133585942,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome --user-data-dir=/tmp/karma-55967824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --disable-web-security --disable-dev-shm-usage http://localhost:9876/?id=55967824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4913 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-39444664 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5706315277108938739,13159022639949838835,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2159818381503667631,12417947849844884018,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
• update.googleapis.com
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4679 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-55967824 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10962815086647567136,14307033486024915863,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11551347510497868719,13263738053133585942,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome --user-data-dir=/tmp/karma-55967824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --disable-web-security --disable-dev-shm-usage http://localhost:9876/?id=55967824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4913 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-39444664 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5706315277108938739,13159022639949838835,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2159818381503667631,12417947849844884018,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
• www.google.com
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4679 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-55967824 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10962815086647567136,14307033486024915863,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,11551347510497868719,13263738053133585942,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
  • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-148.0.7778.97/chrome-linux64/chrome --user-data-dir=/tmp/karma-55967824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --disable-web-security --disable-dev-shm-usage http://localhost:9876/?id=55967824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
  • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4913 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-39444664 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5706315277108938739,13159022639949838835,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2159818381503667631,12417947849844884018,4 --trace-process-track-uuid=3190708989122997041 git (dns block)
• www.googleapis.com
  • Triggering command: /usr/local/bin/node node install.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)