Selection::getPreviousAccessedColumns must return array or null [Closes #160]#161
Open
hranicka wants to merge 1 commit intonette:masterfrom
Open
Selection::getPreviousAccessedColumns must return array or null [Closes #160]#161hranicka wants to merge 1 commit intonette:masterfrom
hranicka wants to merge 1 commit intonette:masterfrom
Conversation
Member
|
What about change |
hranicka
force-pushed
the
hotfix/prev-acc-cols-return
branch
from
0e858b7 to
965148e
Compare
Contributor
Author
|
@dg Right, it's fine. I've changed it, master :-) |
hranicka
changed the title
Contributor
Author
|
Now, tests are failing. Previous changes (return an empty array instead of FALSE) were OK: https://travis-ci.org/nette/database/builds/197590334 |
dg
force-pushed
the
master
branch
4 times, most recently
from
abe9849 to
9358712
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
f1a9aa2 to
ec7a207
Compare
dg
force-pushed
the
master
branch
9 times, most recently
from
5e7169d to
49cbe22
Compare
dg
force-pushed
the
master
branch
14 times, most recently
from
cdb8832 to
a1798c0
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
1769a67 to
b02f117
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
2d78899 to
2f04c73
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
e8459f8 to
23617a8
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
2da238e to
038bab3
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
d3018bd to
9dc391a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just fixed annotation + array return typehint for
Selection::getPreviousAccessedColumns.Fixes #160