Modernization rewrite V2#18
Merged
Merged
Conversation
Remove legacy multi-role structure (roles/, molecule/, claim.yml, purge.yml, netdata-agent.yml, .ansible-lint, group_vars/, host_vars/). Implement single-role layout supporting Debian, Ubuntu, and OpenSUSE with CI workflows for linting and integration testing. Address all review feedback from #16: - Restore trailing period in CODEOWNERS comment - Remove .gitignore per reviewer agreement - Rename netdata_release_version to netdata_release_channel with nightly->edge mapping - Move role version from defaults to meta/main.yml as 0.1.0 - Add explicit GPG key ID to apt_key task - Replace restart handler with netdatacli reload-claiming-state for claims - Remove default insecure=no from claim.conf.j2 - Remove redundant enable_all_charts charts.d.conf task - Consolidate install-ubuntu.yml into install-debian.yml - Remove empty vars/main.yml
The ansible-lint schema[meta] rule does not allow 'version' inside galaxy_info. Move the field to the root level of meta/main.yml to satisfy the reviewer's request while passing lint validation.
Rewrite README.md with accurate platform support (adds Ubuntu, openSUSE), structured usage examples, complete role variables table, and release channel documentation.
Closed
…s/checkout to v6 Remove the top-level 'version' key from meta/main.yml, which is not a valid RoleMetadata attribute and caused all integration test jobs to fail with exit code 4. Update actions/checkout from v4 to v6 in both workflow files to resolve Node.js 20 deprecation warnings.
Install community.general collection explicitly in the opensuse-test CI job, since the openSUSE Leap ansible package does not always bundle it. Remove the Tumbleweed-specific netfilter repository task from install-opensuse.yml. The hardcoded Tumbleweed URL is invalid for Leap systems and caused connection failures. The libnetfilter_acct1 package is available from the standard Leap repositories.
|
@ralphm Just in case you weren't aware :) |
Add when condition to skip libnetfilter_acct1 installation on Leap 16.0+ where the package is unavailable. Restore opensuse/leap:15.5 to the CI matrix with community.general pinned to 3.8.8 for Python 3.6 compat.
…on and 16.0 conditional dependency
The test playbook referenced the role as `../netdata-ansible`, which
Ansible resolves relative to the playbook file (tests/), so it expected
a sibling directory named `netdata-ansible` next to the repo checkout.
In CI the repo is checked out as `ansible` (because the upstream repo
is netdata/ansible), so the parent directory is `ansible`, not
`netdata-ansible`, and Ansible failed with:
ERROR! the role '../netdata-ansible' was not found in ...
Fix it the standard Ansible Galaxy way: add a `tests/roles/netdata`
symlink pointing at the repository root, and have the playbook reference
the role by its declared name (`role: netdata`). Ansible's default
roles_path includes the directory of the playbook, so `tests/roles/`
is searched automatically. This also matches how the role is invoked
in the README.
Contributor
Author
Ferroin
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-implementation of #16 with a clean commit history and addressing the feedback in the prior PR.