fix: Protect against unmounting#3
Open
dignifiedquire wants to merge 1 commit intomzabriskie:masterfrom
Open
Conversation
When the component is unmounted due to a page transition multiple errors occur (`setState` on unmounted component and `this.refs` being empty). This protects against that.
|
I've encountered the same issue, in particular I get the following error logged in a page transition: This PR looks like it should fix this, unfortunately I wasn't able to get the updated code working within my project since as far as I can see there does not seem to be either a compiled ES5 version of it or steps/code to build this within the PR or main project. Any help with the correct way to build this would be appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the component is unmounted due to a page transition
multiple errors occur (
setStateon unmounted component andthis.refsbeing empty).This protects against that.