ARM: dts: qcom: msm8974-samsung-lt03lte: enable wacom digitizer + touchkeys#32
Open
vrajashkr wants to merge 4 commits into
Open
ARM: dts: qcom: msm8974-samsung-lt03lte: enable wacom digitizer + touchkeys#32vrajashkr wants to merge 4 commits into
vrajashkr wants to merge 4 commits into
Conversation
samsung-lt03lte has 2 touch-sensitive keys on the front of the device for Menu and Back. Both these keys are managed by the Atmel Maxtouch driver and hardware. This change adds the necessary DTS changes to enable this functionality. Signed-off-by: Vishwas Rajashekar <dev@vrajashkr.com>
Author
|
Testing the Touchkeys with evtest: |
Author
|
Testing the Wacom digitizer with the passive stylus: |
z3ntu
reviewed
May 7, 2026
| power-source = <PM8941_GPIO_S3>; | ||
| }; | ||
|
|
||
| stylus_insert_pin: stylus-insert-state { |
Author
There was a problem hiding this comment.
It doesn't appear to be used in the mainline driver, but was used in the old downstream driver so I had added it to keep the pins in the right shape earlier.
I've removed this now. Thanks for the feedback!
z3ntu
reviewed
May 7, 2026
|
|
||
| stylus_default_state: stylus-default-state { | ||
| pdct-pins { | ||
| pins = "gpio145"; |
Member
There was a problem hiding this comment.
this gpio is not referenced in the node above? No clue if "pdct" is important - whatever that is
Author
There was a problem hiding this comment.
If I'm not mistaken, pdct is short for pen detect. There was some conversation about it in the mailing list on the driver patch. I believe it was ultimately removed from the driver. I've removed it too.
Thanks!
Member
|
Fwiw the latest revision of the patch series is v7 https://lore.kernel.org/all/20260501124002.132540-1-hendrik-noack@gmx.de/ Would be good to pick that one now, and prefix the patches with "FROMLIST v7 " in the first line of the commit message of those two commits/patches. |
Add bindings for Wacom W9002 and two Wacom W9007 variants which can be found in tablets. W9002, W9007A LT03, and W9007A V1 differ in the length of the return message containing coordinates, distance, pressure and button status. Co-developed-by: Ferass El Hafidi <funderscore@postmarketos.org> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org> Signed-off-by: Hendrik Noack <hendrik-noack@gmx.de> Acked-by: Conor Dooley <conor.dooley@microchip.com> Link: https://patch.msgid.link/20260528074818.12151-2-hendrik-noack@gmx.de Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Add driver for Wacom W9002 and two Wacom W9007A variants. These are penabled touchscreens supporting passive Wacom Pens and use I2C. Co-developed-by: Ferass El Hafidi <funderscore@postmarketos.org> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org> Signed-off-by: Hendrik Noack <hendrik-noack@gmx.de> Link: https://patch.msgid.link/20260528074818.12151-3-hendrik-noack@gmx.de Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This change enables support for the Wacom digitizer (passive stylus) for samsung-lt03lte. This includes the digitizer node and the fixed regulator. Signed-off-by: Vishwas Rajashekar <dev@vrajashkr.com>
vrajashkr
force-pushed
the
lt03lte-wacom-2
branch
from
6907371 to
7d93f85
Compare
Author
Sorry it took me a while to get back to this. Fortunately, it looks like the patch has been accepted and the commits are present in linux-next at the time of writing. I've fetched the patches from there and prefixed them with FROMGIT instead (I came across a few commits with this prefix in the commit history). Let me know in case I should be using a different prefix. |
Author
|
Tested with a fresh kernel build: Seems to be working :) |
z3ntu
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For samsung-lt03lte, enables the wacom digitizer (passive stylus) and the front touchkeys.
The Wacom W9007 driver has been backported from an active kernel patch series.ref: https://patchew.org/linux/20260319095303.19927-1-hendrik-noack@gmx.de/20260319095303.19927-2-hendrik-noack@gmx.de/The Wacom W9007 driver patches have been taken from linux-next:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=185cd1d8cb7f0fd30d868fa12d294bba5997b7c7
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=acaefbacc997ae79527a5ade8720221dfe17407e